reuse ngrok if found in path #1556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerd0
reviewed
May 5, 2021
nishkrishnan
approved these changes
Jun 22, 2021
|
Will merge once you have confirmed that you tested this and it works 🙂 |
|
@nishkrishnan I tested it... and failed. So I published a patch. Now it should be working both when ngrok is found: And when it is not: |
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Sorry.... I've been disconnected for some days. @nishkrishnan , I double-checked it and found several errors that were fixed. I think it can be merged now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids having to wait until ngrok is downloaded when you already have the client in your laptop.